Conversation
Contributor
UI Previewmici: |
| # Steering PID loop and lateral MPC | ||
| # Reset desired curvature to current to avoid violating the limits on engage | ||
| new_desired_curvature = model_v2.action.desiredCurvature if CC.latActive else self.curvature | ||
| if self.sm.recv_frame['lateralManeuverPlan'] > 0 and self.sm.valid['lateralManeuverPlan']: |
Contributor
Author
There was a problem hiding this comment.
using sm.valid as the other optional services do, this does not require ignore.
Contributor
Process replay diff reportReplays driving segments through this PR and compares the behavior to master. ✅ 0 changed, 66 passed, 0 errors |
sshane
reviewed
Mar 24, 2026
sshane
reviewed
Mar 24, 2026
sshane
reviewed
Mar 24, 2026
sshane
reviewed
Mar 24, 2026
sshane
reviewed
Mar 24, 2026
Collaborator
Contributor
|
@sshane Adeeb broke recording on ffmpeg here I believe (I think for hardware that doesn't support HW acceleration): |
FrogAi
pushed a commit
to FrogAi/FrogPilot
that referenced
this pull request
Apr 3, 2026
* lateral report * mutually exclude buttons * gating * set maneuver * add timer * timer text * fix plot * use curvature * more curves * fix gating * rm delay * highway speed only * msg * add sine * add step-down * use relative * text * stabilize * tuning * windup * text * winddown * no windup * tuning * more tuning * more * formatting * test faster * extend sine * report crossings * add readme * clean report * fix lint * gating * fix * straighter * compensate roll * rm abs roll * len * Revert "rm abs roll" This reverts commit a22d6bb. * Revert "compensate roll" This reverts commit dfda521. * print actuators * show curve and roll * tune roll * text * slower * timer * too much banked streets in US * readme * filter incomplete * plot jerk * plot angle jerk * lil edits * fix lint * apply suggestions * better table * apply comments * clean * shane comments * deflicker --------- Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
AlexandreSato
pushed a commit
to AlexandreSato/openpilot
that referenced
this pull request
Apr 20, 2026
* lateral report * mutually exclude buttons * gating * set maneuver * add timer * timer text * fix plot * use curvature * more curves * fix gating * rm delay * highway speed only * msg * add sine * add step-down * use relative * text * stabilize * tuning * windup * text * winddown * no windup * tuning * more tuning * more * formatting * test faster * extend sine * report crossings * add readme * clean report * fix lint * gating * fix * straighter * compensate roll * rm abs roll * len * Revert "rm abs roll" This reverts commit a22d6bb. * Revert "compensate roll" This reverts commit dfda521. * print actuators * show curve and roll * tune roll * text * slower * timer * too much banked streets in US * readme * filter incomplete * plot jerk * plot angle jerk * lil edits * fix lint * apply suggestions * better table * apply comments * clean * shane comments * deflicker --------- Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
montge
added a commit
to montge/openpilot
that referenced
this pull request
May 11, 2026
Two follow-on issues discovered when running pytest against the merged schema migration: 1. Import: use vendored openpilot.common.parameterized (project standard per the merge conflict resolution) instead of the third-party parameterized package, which is no longer in the venv. 2. SubMaster fixtures: controlsd.py now subscribes to lateralManeuverPlan (added by upstream PR commaai#37562). Add it to all 11 mock service lists so self.sm.valid['lateralManeuverPlan'] doesn't KeyError. pytest selfdrive/controls/tests/test_controlsd.py: 60 passed in 3.53s.
cursor Bot
pushed a commit
to jmbrunick/openpilot
that referenced
this pull request
Sep 16, 2026
* lateral report * mutually exclude buttons * gating * set maneuver * add timer * timer text * fix plot * use curvature * more curves * fix gating * rm delay * highway speed only * msg * add sine * add step-down * use relative * text * stabilize * tuning * windup * text * winddown * no windup * tuning * more tuning * more * formatting * test faster * extend sine * report crossings * add readme * clean report * fix lint * gating * fix * straighter * compensate roll * rm abs roll * len * Revert "rm abs roll" This reverts commit a22d6bb. * Revert "compensate roll" This reverts commit dfda521. * print actuators * show curve and roll * tune roll * text * slower * timer * too much banked streets in US * readme * filter incomplete * plot jerk * plot angle jerk * lil edits * fix lint * apply suggestions * better table * apply comments * clean * shane comments * deflicker --------- Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
triet228
pushed a commit
to triet228/TrietPilot
that referenced
this pull request
Sep 18, 2026
* lateral report * mutually exclude buttons * gating * set maneuver * add timer * timer text * fix plot * use curvature * more curves * fix gating * rm delay * highway speed only * msg * add sine * add step-down * use relative * text * stabilize * tuning * windup * text * winddown * no windup * tuning * more tuning * more * formatting * test faster * extend sine * report crossings * add readme * clean report * fix lint * gating * fix * straighter * compensate roll * rm abs roll * len * Revert "rm abs roll" This reverts commit a22d6bb. * Revert "compensate roll" This reverts commit dfda521. * print actuators * show curve and roll * tune roll * text * slower * timer * too much banked streets in US * readme * filter incomplete * plot jerk * plot angle jerk * lil edits * fix lint * apply suggestions * better table * apply comments * clean * shane comments * deflicker --------- Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Lateral maneuver report
Disclaimer: Do not use this tool on public roads.
Description:
Adds lateral maneuver mode that works in a similar way to longitudinal maneuver mode.
The tool commands lateral acceleration steps at different speeds to profile steering response.
Usage:
Check out a development branch such as
masteron the comma device.Enable "Lateral Maneuver Mode" in Settings > Developer on the device while offroad. Alternatively, set the parameter manually:
Turn the vehicle back on. Comma will show "Lateral Maneuver Mode".
Openpilot will command lateral acceleration steps in this mode. Once ready, set ACC manually to the target speed shown on screen and let openpilot stabilize lateral. After 3 seconds of steady straight driving, the maneuver will begin automatically. Openpilot lateral control stays engaged between maneuvers normally while waiting for the next maneuver's readiness conditions. The maneuver will be aborted and repeated if speed is out of range, steering is touched or openpilot disengages.
When the testing is complete, an alert shows "Maneuvers Finished." Complete the route by pulling over and turning off the vehicle.
As with the longitudinal report, get the route ID from connect.comma.ai and generate the report:
python tools/lateral_maneuvers/generate_report.py 98395b7c5b27882e/000001cc--5a73bde686Verification
Report for Kia EV6:
KIA_EV6_98395b7c5b27882e_000001cc--5a73bde686.html