ui: param thread - #38029
Merged
Merged
ui: param thread#38029
Conversation
Contributor
|
we might want to just rearchitect params such that read/writes are always guaranteed to be non-blocking, then have a service sync the buffer to disk periodically |
Collaborator
Author
|
Yes that would be nice, I couldn't easily remove many blocking param puts because we rely on it being set immediately after. https://github.com/sshane/opParams was 7 years too early |
Contributor
UI Previewmici: Videos are identical! View Diff Report |
Contributor
Process replay diff reportReplays driving segments through this PR and compares the behavior to master. ✅ 0 changed, 66 passed, 0 errors |
erikfleischer
pushed a commit
to erikfleischer/openpilot
that referenced
this pull request
May 22, 2026
* ui param thread * 5hz * later * rename * temp * clean up * no ui mutate from thread * cmt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from #37980
before/after (see uiStateUpdateTime)