Normalize Windows backslashes - #54
Merged
Merged
Conversation
On Windows, fileSystemUtil.makePathRelative() returns paths using backslash separators (e.g. resources\database\migrations\). The previous fix attempted to normalize these with replace( path, "\\", "/", "all" ), but in CFML "\\" is a two-character string literal matching double backslashes \\ — not the single backslashes \ that Windows paths actually contain. As a result, the replace was a no-op on Windows and the bug persisted. This fix corrects the string literal to "\" (single backslash) in all three affected locations: setup() — migrationsDirectory normalization setup() — seedsDirectory normalization setMigrationPath() — direct directory setter This change has no effect on Mac or Linux, where makePathRelative() already returns forward-slash paths and the replace() is a no-op either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, fileSystemUtil.makePathRelative() returns paths using backslash separators (e.g. resources\database\migrations). The previous fix attempted to normalize these with replace( path, "\", "/", "all" ), but in CFML "\" is a two-character string literal matching double backslashes \ — not the single backslashes \ that Windows paths actually contain. As a result, the replace was a no-op on Windows and the bug persisted.
This fix corrects the string literal to "" (single backslash) in all three affected locations:
setup() — migrationsDirectory normalization
setup() — seedsDirectory normalization
setMigrationPath() — direct directory setter
This change has no effect on Mac or Linux, where makePathRelative() already returns forward-slash paths and the replace() is a no-op either way.
Type of change