Skip to content

Exclude gift card/coupon errors from blocking place order#725

Merged
acasazza merged 4 commits into
mainfrom
fix/place-order-button-gift-card-error
Mar 24, 2026
Merged

Exclude gift card/coupon errors from blocking place order#725
acasazza merged 4 commits into
mainfrom
fix/place-order-button-gift-card-error

Conversation

@acasazza

Copy link
Copy Markdown
Member

Summary

When a user enters an invalid or fake gift card/coupon code, the Place Order button was incorrectly disabled until the input was cleared.

Gift card and coupon code errors are non-blocking — the order should still be placeable without a valid gift card applied.

Changes

  • Filter out gift_card_code, coupon_code, and gift_card_or_coupon_code errors from the blocking check in PlaceOrderButton
  • Only order-level errors (billing address, payment method, etc.) now disable the button

Closes #724

…g place order

Gift card and coupon code errors are non-blocking — the user should still
be able to place the order without a valid gift card applied.

Closes #724
@netlify

netlify Bot commented Mar 19, 2026

Copy link
Copy Markdown

Deploy Preview for commercelayer-react-components failed.

Name Link
🔨 Latest commit 05f4d89
🔍 Latest deploy log https://app.netlify.com/projects/commercelayer-react-components/deploys/69c182313d564c0008157907

@acasazza acasazza added the bug Something isn't working label Mar 19, 2026
@acasazza acasazza self-assigned this Mar 19, 2026
…rades

- Bump lerna from ^9.0.3 to ^9.0.7
- Bump storybook from ^8.0.0 to ^8.6.17 (WebSocket hijacking fix)
- Add pnpm.overrides to patch transitive vulns: tar, rollup, minimatch, ajv, esbuild

Resolves 25 vulnerabilities (24 high, 1 moderate) → 0
@pkg-pr-new

pkg-pr-new Bot commented Mar 23, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/@commercelayer/react-components@725

commit: 05f4d89

@malessani
malessani self-requested a review March 24, 2026 15:17
@malessani malessani changed the title 🐛 fix(PlaceOrderButton): exclude gift card/coupon errors from blocking place order Exclude gift card/coupon errors from blocking place order Mar 24, 2026
@acasazza
acasazza merged commit feb8b4c into main Mar 24, 2026
4 of 8 checks passed
@acasazza
acasazza deleted the fix/place-order-button-gift-card-error branch March 24, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Place Order button disabled on gift card error even though gift card is optional

2 participants