Add maintenance guardrails for content rules and toolchain#73
Merged
Conversation
VatsalSy
approved these changes
Mar 16, 2026
Bump jest and jest-environment-jsdom to 30.3.0 so the test stack no longer pulls @tootallnate/once through jsdom/http-proxy-agent. Adjust the affected jsdom tests to update the URL via history.replaceState instead of redefining window.location, which is no longer writable under the newer environment.
There was a problem hiding this comment.
Pull request overview
Adds maintenance guardrails to keep CI/workflows, scripts, and docs aligned (content-rule validation triggers, deploy.sh edge cases, add-news bullet counting fixtures, and Ruby/Bundler toolchain pinning).
Changes:
- Adds trigger-parity validation for the content-rules workflow and expands workflow path filters.
- Adds regression tests + a dedicated workflow for deploy.sh edge cases and add-news bullet counting fixtures.
- Pins Ruby/Bundler versions across CI + setup docs/scripts and adds a toolchain preflight check.
Reviewed changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
scripts/check-content-rules-trigger-parity.py |
New guardrail ensuring workflow trigger paths match files validated by validate-content-rules.sh. |
.github/workflows/content-rules-checks.yml |
Expands trigger paths and runs the new parity check before validation. |
scripts/deploy.sh |
Improves --host validation to accept bracketed IPv6 literals with a clearer error message. |
tests/deploy-script-regression.sh |
New bash regression tests covering deploy.sh port/livereload/IPv6/validation behavior. |
.github/workflows/maintenance-regression-checks.yml |
New workflow to run deploy/add-news regressions only when relevant files change. |
tests/news-bullet-regression.test.js |
New Jest regression tests verifying top-level - bullet counting behavior against fixtures. |
tests/fixtures/news-bullets/*.md |
Fixtures for frontmatter, nested bullets, and special announcement blocks. |
scripts/check-ruby-toolchain.sh |
New toolchain preflight enforcing Ruby/Bundler versions from repo-pinned files. |
.github/workflows/jekyll.yml |
Pins Ruby/Bundler in CI and runs toolchain preflight. |
scripts/setup.sh |
Aligns setup with pinned Ruby/Bundler and runs the toolchain preflight. |
README.md |
Updates setup docs to reference pinned Bundler and the toolchain preflight. |
.github/PULL_REQUEST_TEMPLATE/default.md |
Adds checklist items to reduce scope creep and ensure review threads are resolved. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
comphy-bot
added a commit
that referenced
this pull request
Mar 21, 2026
- weekly-tests.yml: add content-rules parity, validate-content-rules, deploy regression, news-bullet/stale-search targeted tests, teaching markdown lint, ruby toolchain check, and jekyll build to the weekly schedule so maintenance guardrails from PRs #73/#76 run continuously - tests/utils.test.js: 18 new Jest tests covering initScrollReveal (IO available + unavailable + no blocks), copyToClipboard (clipboard API, execCommand fallback, rejected clipboard, missing text, attribute variants), safeQuery/safeQueryAll (valid, no-match, invalid selector, context), and window.Utils export shape - pr-hygiene-check.yml: new workflow that warns when a dependency/security PR also changes unrelated app/content files; warning-only mode, suppress with 'mixed-changes-ok' label, flip ENFORCE=true to hard-fail - PR template: add checklist item requiring a regression test or linked follow-up issue for every accepted review finding that identifies a reproducible bug or edge case
10 tasks
VatsalSy
added a commit
that referenced
this pull request
Jun 29, 2026
…view-followups Add maintenance guardrails for content rules and toolchain
VatsalSy
pushed a commit
that referenced
this pull request
Jun 29, 2026
- weekly-tests.yml: add content-rules parity, validate-content-rules, deploy regression, news-bullet/stale-search targeted tests, teaching markdown lint, ruby toolchain check, and jekyll build to the weekly schedule so maintenance guardrails from PRs #73/#76 run continuously - tests/utils.test.js: 18 new Jest tests covering initScrollReveal (IO available + unavailable + no blocks), copyToClipboard (clipboard API, execCommand fallback, rejected clipboard, missing text, attribute variants), safeQuery/safeQueryAll (valid, no-match, invalid selector, context), and window.Utils export shape - pr-hygiene-check.yml: new workflow that warns when a dependency/security PR also changes unrelated app/content files; warning-only mode, suppress with 'mixed-changes-ok' label, flip ENFORCE=true to hard-fail - PR template: add checklist item requiring a regression test or linked follow-up issue for every accepted review finding that identifies a reproducible bug or edge case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deploy.shedge cases and the add-news bullet matcherChanges
scripts/check-content-rules-trigger-parity.pyand wire it intocontent-rules-checks.ymlscripts/deploy.sh --hostvalidation to accept bracketed IPv6 literals and report the constraint clearlytests/deploy-script-regression.shplus a newmaintenance-regression-checks.ymlworkflow for deploy/add-news regressions on relevant PRstests/news-bullet-regression.test.jswith fixtures covering frontmatter delimiters, nested bullets, and special announcement blocksscripts/check-ruby-toolchain.sh, pin CI to Ruby3.2.2+ Bundler2.5.23, and updatescripts/setup.sh/README.mdto use the same toolchain and preflightTesting
python3 scripts/check-content-rules-trigger-parity.pybash -n scripts/deploy.shbash -n scripts/setup.shbash -n scripts/check-ruby-toolchain.shbash tests/deploy-script-regression.shruby -e 'require "yaml"; YAML.load_file(".github/workflows/content-rules-checks.yml"); YAML.load_file(".github/workflows/jekyll.yml"); YAML.load_file(".github/workflows/maintenance-regression-checks.yml"); puts "yaml ok"'npm test -- --runInBand tests/news-bullet-regression.test.js./scripts/check-ruby-toolchain.sh(fails on this machine as expected: active Ruby is2.6.10, repo requires3.2.2)