Skip to content

shouldnt assume hide is removing #18

Description

@ianstormtaylor

i dont think it should assume you want to remove the overlay when you are just hiding it.

in my case, adding a modal to the page and it can be opened/closed multiple times. currently i'd have to manually reattach the overlay each time, whereas if i really wanted that functionality i dont think its that hard to do hide().remove()

altho since hiding should be async (animations), it might be better to have it take a callback:

overlay.hide(function () {
  overlay.remove();
});

what do you think? i can PR this functionality if you want it @visionmedia

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions