Skip to content

Add ability to open files - #45

Merged
conaticus merged 4 commits into
devfrom
file_opening
Jul 1, 2023
Merged

Add ability to open files#45
conaticus merged 4 commits into
devfrom
file_opening

Conversation

@conaticus

Copy link
Copy Markdown
Owner

No description provided.

@conaticus conaticus added the enhancement New feature or request label Jun 30, 2023
@conaticus
conaticus requested a review from LeoCatsune June 30, 2023 21:34
Comment thread src-tauri/src/filesystem/mod.rs Outdated
@conaticus

conaticus commented Jun 30, 2023

Copy link
Copy Markdown
Owner Author

Found a mistake, also going to change the tauri command to return a string if an error occurs.

@LeoCatsune LeoCatsune left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks decent, but some changes needed.

Comment thread src-tauri/src/filesystem/mod.rs Outdated
Comment thread src-tauri/src/filesystem/mod.rs Outdated
@conaticus
conaticus dismissed LeoCatsune’s stale review July 1, 2023 10:21

issues resolved

@conaticus
conaticus merged commit 80c1145 into dev Jul 1, 2023
@conaticus conaticus mentioned this pull request Jul 1, 2023
@conaticus
conaticus deleted the file_opening branch July 1, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants