fix(tui): keep theme cycle clickable after switch - #1155
Merged
Conversation
Successful theme apply no longer sets a transient status message. That status was preempting the right-aligned modeline notices (theme, remote, version) and their click targets for ~5s whenever left content collided with the notice block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
theme:<name>on the modeline no longer posts a left-side status liketheme: basic.theme:… | remote | version) and drop its hit zones until the ~5s status timer expired, so rapid cycle clicks felt stuck.theme:<name>label itself; failures still surface via status.Test plan
cargo test -p construct-cli --bin construct cycle_theme_keeps_persistent_notices_clickabletheme:<name>repeatedly on a mid-width terminal; notices stay put and each click advances the theme with no multi-second dead zone