tui/webui: title the ambient pane 'monitor' - #1256
Merged
Merged
Conversation
The matrix-rain/token-meter pane's leftmost header text was 'minibuffer', which read as the pane's title and collided with the actual minibuffer (the dispatcher session in the bottom strip). The pane is the fleet's ambient monitor — name it that. 'monitor' also matches existing vocabulary: the smith adapter already describes the minibuffer's ambient role as a monitor and the loop model env var is CONSTRUCT_MINIBUFFER_MONITOR_MODEL. The default sidebar is too narrow for a separate title plus minibuffer chip, so the existing label is renamed in place. Click-to-open, the loop toggle, the approval alert, and the hover tooltip (which still names the minibuffer) are unchanged. - TUI: header reads 'monitor' / 'monitor !'; collapse tooltips now say Expand/Collapse monitor. - Web UI: panel title and aria labels renamed; internal ids/classes keep the minibuffer- prefix (invisible vocabulary). - Specs 0019/0081/0186 amended: 'minibuffer' must never double as this pane's name.
Contributor
Author
Before / after stillsSame vhs tape against Stills (gist, data-URI markdown so the frames travel with the file): Local artifacts (open these to see the actual frames):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The matrix-rain / token-meter pane's leftmost header text was
minibuffer, which read as the pane's title and collided with the actual minibuffer (the dispatcher session in the bottom strip).This pane is the fleet's ambient monitor — rain intensity, token usage, sticky widgets.
monitoris also existing vocabulary: the smith adapter already describes the minibuffer's ambient role as a monitor, and the loop model env var isCONSTRUCT_MINIBUFFER_MONITOR_MODEL.What changes
monitor/monitor !. Click-to-open, the ▶/⏸ loop toggle, the approval alert, and the hover tooltip (which still names the minibuffer) are unchanged. Collapse tooltips now say Expand/Collapse monitor.monitor. Internal ids/classes keep theminibuffer-prefix (invisible vocabulary).minibuffermust never double as this pane's name.The default sidebar (~40 cols) has no room for a separate title plus a
minibufferchip — a first attempt at that split pushed the widget squares off the bar. So the existing label is renamed in place.Before / after
Stills from isolated vhs recordings of the same tape against
mainvs this branch (see the follow-up comment for the frames).Notes
crates/cli(TUI header) andcrates/daemon/assets(web panel title) → the relevant binary isconstruct:.claude/worktrees/monitor-pane-title/target/debug/constructcargo test -p construct-cli --bin construct: 1402 passed. The one failure (color::tests::truecolor_backend_still_emits_rgb) is an unrelated RGB-escape assertion and does not touch this header.