fix(tui): keep pane ordinals above playbooks - #1266
Merged
Merged
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What
Paint split-pane ordinal badges in the final pane-overlay pass, after rolled-down Playbooks and transition overlays. This keeps each badge visible at its pane corner regardless of which pane surface is open.
Adds a regression test covering a rolled-down Playbook in a split layout.
Why
PR #1257 made pane ordinals both locators and addresses, but the Playbook compositor ran after the leaf-local badge paint and covered the active pane badge. The accepted spec already requires badges to be painted after pane content and transient overlays.
Testing
cargo buildcargo test -p construct-cli ordinal_badge -- --nocapture(5 passed)cargo test -p construct-cli -- --skip color::tests::truecolor_backend_still_emits_rgb(1,411 unit tests + reconnect integration test passed)color::tests::truecolor_backend_still_emits_rgbfailure; reproduced unchanged onmain.This PR only touches
crates/cli→ relevant binary isconstruct.