Skip to content

fix(tui): keep pane ordinals above playbooks - #1266

Merged
edwin-zvs merged 1 commit into
mainfrom
fix-playbook-ordinal-badge
Aug 18, 2026
Merged

fix(tui): keep pane ordinals above playbooks#1266
edwin-zvs merged 1 commit into
mainfrom
fix-playbook-ordinal-badge

Conversation

@edwin-zvs

Copy link
Copy Markdown
Contributor

What

Paint split-pane ordinal badges in the final pane-overlay pass, after rolled-down Playbooks and transition overlays. This keeps each badge visible at its pane corner regardless of which pane surface is open.

Adds a regression test covering a rolled-down Playbook in a split layout.

Why

PR #1257 made pane ordinals both locators and addresses, but the Playbook compositor ran after the leaf-local badge paint and covered the active pane badge. The accepted spec already requires badges to be painted after pane content and transient overlays.

Testing

  • cargo build
  • cargo test -p construct-cli ordinal_badge -- --nocapture (5 passed)
  • cargo test -p construct-cli -- --skip color::tests::truecolor_backend_still_emits_rgb (1,411 unit tests + reconnect integration test passed)
  • Full unfiltered CLI suite has the existing color::tests::truecolor_backend_still_emits_rgb failure; reproduced unchanged on main.

This PR only touches crates/cli → relevant binary is construct.

@edwin-zvs

Copy link
Copy Markdown
Contributor Author

Before — badge covered by rolled-down Playbook:

clipboard

After — badge remains visible above the rolled-down Playbook:

clipboard

@edwin-zvs
edwin-zvs merged commit 5e26b56 into main Aug 18, 2026
1 check passed
@edwin-zvs
edwin-zvs deleted the fix-playbook-ordinal-badge branch August 18, 2026 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant