Skip to content

feat(blueprint-types): snake_case fields, new types, GraphQLSchema_types hook #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pyramation wants to merge 1 commit into from
Closed

feat(blueprint-types): snake_case fields, new types, GraphQLSchema_types hook #907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions graphile/graphile-settings/__tests__/blueprint-types-plugin.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ describe('createBlueprintTypesPlugin', () => {
expect(plugin.schema!.hooks).toBeDefined();
expect(plugin.schema!.hooks!.init).toBeDefined();
expect(plugin.schema!.hooks!.GraphQLInputObjectType_fields).toBeDefined();
expect(plugin.schema!.hooks!.GraphQLSchema_types).toBeDefined();
});

it('works with an empty node types array', () => {
Expand Down Expand Up @@ -248,6 +249,24 @@ describe('jsonSchemaToGraphQLFieldSpecs', () => {
expect(Object.keys(specs)).toHaveLength(0);
});

it('uses snake_case field names (matching JSONB format)', () => {
const schema = {
type: 'object' as const,
properties: {
table_name: { type: 'string', description: 'The table name' },
grant_roles: { type: 'array', items: { type: 'string' } },
use_rls: { type: 'boolean' },
},
};

const specs = jsonSchemaToGraphQLFieldSpecs(schema, 'TestParams', mockBuild);

// Field names should be preserved as-is (snake_case)
expect(specs.table_name).toBeDefined();
expect(specs.grant_roles).toBeDefined();
expect(specs.use_rls).toBeDefined();
});

it('falls back to String for unknown types', () => {
const buildWithJson: BuildLike = {
...mockBuild,
Expand Down
Loading
Loading