Default to keep-alive agents in Node environments for better performance - #241
Draft
reeshika-h wants to merge 2 commits into
Draft
Default to keep-alive agents in Node environments for better performance#241reeshika-h wants to merge 2 commits into
reeshika-h wants to merge 2 commits into
Conversation
httpAgent/httpsAgent defaulted to false, so every request opened a fresh TCP/TLS connection with zero reuse - relevant under Next.js prerendering concurrency, where redundant connection setup adds latency that pushes more requests toward the request timeout. Default to a keepAlive http.Agent/https.Agent instead, guarded behind a Node-only runtime check (typeof window === 'undefined', matching the existing isBrowser() convention in contentstack-typescript) since @contentstack/core has no browser field to redirect Node-only imports away from browser bundles the way axios does for itself. A fresh agent is created per httpClient() call rather than a shared module-level singleton - a deliberate tradeoff to avoid shared state across separate stack() instances in the same process. No behavior change for callers who already set their own httpAgent/ httpsAgent (including explicit false), and no behavior change at all in browser environments. DX-9991
Removes duplication between the httpAgent and httpsAgent defaults. DX-9991
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.