Skip to content

Set Node 24 floor for corbits-artifacts - #14

Merged
TheGreatAxios merged 1 commit into
mainfrom
cl-8540-set-node-24-floor-for-corbitsartifacts
Sep 21, 2026
Merged

TheGreatAxios merged 1 commit into
mainfrom
cl-8540-set-node-24-floor-for-corbitsartifacts

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Contributor

Sets the Node floor to 24 LTS (CL-8540).

Summary:

  • engines.node >=22 to >=24
  • CI test matrix covers Node 24 via setup-node for the consumer smoke test
  • README requirements state the Node 24 floor
  • package.json author set to Sawyer Cutler sawyer@dirtroad.dev

Verification:

  • bun run typecheck: pass
  • bun run build: pass
  • bun run test:coverage: 283 pass, 0 fail
  • bun test --cwd examples/reference-host: 35 pass, 0 fail
  • npm pack --dry-run: pass (129.2 kB tarball, 88 files)
  • node consumer smoke test on v24.4.1: pass

@TheGreatAxios

Copy link
Copy Markdown
Contributor Author

Review

Verdict: approve. Coordinate with #11; rebase onto current main first. CI test (24) green. No prior reviews.

engines >=24, README Runtime Node 24+, setup-node for the existing tarball smoke. Single-value matrix is ceremony (mailbox #27 just pins node-version 24). Overlaps #11 on author, README, workflow — land one then rebase the other.

@TheGreatAxios
TheGreatAxios force-pushed the cl-8540-set-node-24-floor-for-corbitsartifacts branch from 25f45dd to 26fe38d Compare September 21, 2026 04:04
@TheGreatAxios

Copy link
Copy Markdown
Contributor Author

Re-review

Rebased onto main (#11). SHA 26fe38d.

README: Node 24+ and Bun 1.2+, intx 0.3.0. engines.node >=24. Workflow still adds setup-node 24 for the consumer smoke.

CI after force-push may still be running (UNSTABLE). Merge in the GitHub UI — gh lacks workflow scope for this file.

@TheGreatAxios
TheGreatAxios merged commit 873c4c7 into main Sep 21, 2026
1 check passed
@TheGreatAxios
TheGreatAxios deleted the cl-8540-set-node-24-floor-for-corbitsartifacts branch September 21, 2026 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant