refactor!: remove skill-draft, web_site handling and mail attachments - #30
Open
Conversation
TheGreatAxios
commented
Sep 25, 2026
TheGreatAxios
left a comment
Contributor
Author
There was a problem hiding this comment.
Self-review: an independent review checked migration idempotency, tenant scoping, and leftover references. No leftovers found. Upgrade from a 0.1.0 database proven against real Postgres.
TheGreatAxios
force-pushed
the
cl-9068-artifacts-remove-skill-draft-web_site-handling-and-mail
branch
3 times, most recently
from
September 25, 2026 23:57
c71399f to
070bb3c
Compare
This was referenced Sep 25, 2026
TheGreatAxios
force-pushed
the
cl-9068-artifacts-remove-skill-draft-web_site-handling-and-mail
branch
from
September 26, 2026 01:29
070bb3c to
b1ed815
Compare
skill-draft is an ordinary kind and web_site content is stored as given. The mail-attachment routes, helpers and table are gone: 0001 no longer creates mail_attachment_ref, a new migration drops it from upgraded databases, and an end-to-end test upgrades a database written by the published 0.1.0. windowContent is no longer exported.
TheGreatAxios
force-pushed
the
cl-9068-artifacts-remove-skill-draft-web_site-handling-and-mail
branch
from
September 26, 2026 01:37
b1ed815 to
e231702
Compare
TheGreatAxios
added this pull request to stack #32
September 26, 2026 01:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skill-draftis an ordinary kind;SKILL_DRAFT_KINDand every check against it are gone.web_sitehas no special handling;web-site.ts, its exports, andartifact_read'spathare gone.0001no longer createsmail_attachment_ref, and0003_drop_mail_attachment_refdrops it from upgraded databases.windowContentis internal totools.ts.tests/upgrade-from-0.1.0.test.tsmigrates and writes a real database with the published@corbits/artifacts@0.1.0(dev alias), then runs this version's migrations over it.Verification
bun install --frozen-lockfile,bun run typecheck,bun run build: pass.bun run test:coverageagainst local Postgres 16 (ARTIFACT_DATABASE_URL=.../artifact_core,ALLOW_DESTRUCTIVE_ARTIFACT_TESTS=1): 288 pass, 0 fail, coverage floor met.Closes CL-9068