fix(routes): return 4xx instead of 500 for size, cursor and archived errors - #36
Merged
TheGreatAxios merged 1 commit intoSep 27, 2026
Conversation
…errors An upload filename over the title limit is 400. A list cursor must be the updatedAt__id shape the API emits, so a date Postgres would refuse is 400. The workflow routes map ArtifactNotFoundError to 404 and ArtifactSizeError to 400.
TheGreatAxios
added this pull request to stack #32
September 27, 2026 00:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /artifacts/uploadmapsArtifactSizeErrorto 400, asPOST /artifactsdoes, so a filename over 512 characters no longer 500s.YYYY-MM-DDTHH:MM:SS.ffffffZ__idshape the API emits, and rejects dates thatDate.parserolls over but Postgres refuses (for example Feb 30). Those are 400 instead of 500.POST /artifactsandPATCH /artifacts/:idmapArtifactNotFoundError(including an archived artifact) to 404 andArtifactSizeErrorto 400.Verification
bun run check,bun run build: pass.bun run test:coverageagainst local Postgres: 297 pass, 0 fail. The four new tests fail without the fix.Closes CL-9430