fix(tui): handle composed Option-D in model picker - #1141
Merged
Merged
Conversation
Contributor
|
All contributors have signed the CLA. |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
TheGreatAxios
left a comment
Collaborator
There was a problem hiding this comment.
Approve — the composed Option-D handling is correct and well-scoped.
What I verified:
- The dispatch chain works end to end: composed ∂ (no modifiers) bypasses the filter only when the set-default hint is showing in the model picker, then flows through the overlay action into the existing set-default handler (55/55 tests in product-host.test.ts pass, including the 3 new/updated cases).
- No input gets swallowed: outside the picker, ∂ stays ordinary filter text, and bare ASCII d still requires the modifier — typing is unaffected. The single-entry glyph set is complete since ∂ has no uppercase variant.
- The sentinel change (swallow instead of fall-through on no-matches) fixes real prompt pollution — previously the chord leaked into the prompt. The Alt+D expectation flip is the same fix on the modifier path, consistent.
- Architecture is right: normalization lives at the overlay-action layer rather than global input (where ∂ is legitimate text elsewhere), mirrors the existing Option-A precedent, and the composition is terminal-generic rather than iTerm-specific.
Two follow-ups, neither blocking:
- Alt+F (favorite) has the same composed-glyph gap on the sentinel — worth a ticket if anyone hits it there.
- Each new chord repeats the glyph-allowlist discovery cycle; fine as-is given the scoped-predicate pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
∂glyph some terminals (e.g. iTerm with a US layout) emit for Option+D instead of a modifier-flaggedd, mirroring the existing Option+A handling for the add-provider shortcut.∂still types as ordinary filter text.∂are now consumed as a no-op rather than falling through, so an empty model id can never reach the default-setting callback.Verification
bun run typecheck,bun run build, andbun run testpass (7747 pass, 0 fail)product-host.test.tscover composed-∂ set-default, composed-∂ as plain filter text outside the model picker, and the no-matches-sentinel case for both the real chord and the composed glyphFixes CL-8635
🤖 Generated with Claude Code