CL-8792: allow-once no longer stalls a second destructive command without re-prompt - #1173
Open
TheGreatAxios wants to merge 3 commits into
Open
TheGreatAxios wants to merge 3 commits into
TheGreatAxios wants to merge 3 commits into
Conversation
Allow-once settles exactly once and frees the single-slot overlay host, so an already-queued or newly raised card paints before any deferred slash/settings/MCP surface. Command surfaces suspend and return after the gate settles; inline popups keep their stacking contracts.
Suspend was a dismiss: it ran onCancel/onDispose and destroyed the list, so restore painted a dead widget and MCP could steal the host from the arriving gate. The preemptable-kind set also used command aliases, so /model and /connect never yielded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements CL-8792 on the single-slot overlay host.
What changes:
Verification:
Flagging warden review: this touches the permission-gate overlay path (gate-wire, overlay host suspend/resume). Do not merge without warden review.
Fixes CL-8792