fix(secret-guard): expand variables and close glob bypasses - #1196
Open
TheGreatAxios wants to merge 11 commits into
Open
TheGreatAxios wants to merge 11 commits into
TheGreatAxios wants to merge 11 commits into
Conversation
Tokens like $HOME/.env or ${CFG}/settings.json skipped every shell filter through a blanket includes("$") exemption, so secret-guard never prompted for them. Expand $VAR, ${VAR}, ${VAR:-default}, and ~ against process.env only (never shells out) at the top of isSensitiveShellToken; unexpandable references fail closed to a prompt while single-quoted command substitution stays literal. cmd keeps $ literal so ADS paths such as .flaskenv::$DATA still match.
TheGreatAxios
force-pushed
the
cl-8999-secret-guard-dollar
branch
from
September 28, 2026 20:02
1a01620 to
7980a30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?,[…], dotfile-rooted*, and localfile:URL brace globs while keeping remote URL brace syntax exempt.@filehandling for separate follow-up work.Verification
bun test src/plugins/secret-guard-plugin.test.ts src/permission/auto-shell-policy.test.ts: 216 pass, 0 fail.bun test src/shell src/permission --randomize --seed 424242: 941 pass, 0 fail.bun run buildpasses.bun run checkpasses formatting and lint, then stops at the pre-existing missingsemverdeclaration invendor/intx-types.Fixes CL-8999