Skip to content

fix(permissions): resolve advertised tool aliases in approval snapshots - #1223

Merged
TheGreatAxios merged 4 commits into
mainfrom
cl-9477-parity-defs
Sep 29, 2026
Merged

TheGreatAxios merged 4 commits into
mainfrom
cl-9477-parity-defs

Conversation

@TheGreatAxios

@TheGreatAxios TheGreatAxios commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Every advertised authorizable name resolves at approval-snapshot build: authz parity definitions add one renamed copy per alias alongside each tool definition, so ask-tier bash/shell calls suspend for approval instead of throwing a wiring-defect error
  • The chat agent tools factory and the leaf subagent tools factory serve the parity set through a wrapper that delegates run and dispatch verbatim, leaving the advertised wire set byte-identical

Verification

  • bun run check passes (lint, typecheck, dead-exports, build, and the guarded test suite: 7570 pass, 0 fail)
  • Reactor coverage proves allow, ask-suspend/resume, and deny for wire aliases, and proves a genuinely missing definition still throws

Fixes CL-9477

@linear-code

linear-code Bot commented Sep 29, 2026

Copy link
Copy Markdown

CL-9477

The reactor authz snapshot is keyed by parked wire name, so an ask-tier bash/shell call without a parity copy throws a wiring-defect error instead of suspending. Emit one renamed copy per alias alongside every definition and wrap the leaf and chat bundles so the authz-facing set gains the copies while the advertised wire set stays byte-identical.
@TheGreatAxios TheGreatAxios changed the title CL-9477: add authz parity definitions for aliased tools fix(permissions): resolve advertised tool aliases in approval snapshots Sep 29, 2026
@TheGreatAxios
TheGreatAxios merged commit 84a2ead into main Sep 29, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant