Skip to content

Re-sign compiled macOS binaries so bun compile output launches on macOS 27 #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheGreatAxios merged 2 commits into from
Sep 13, 2026
Merged

Re-sign compiled macOS binaries so bun compile output launches on macOS 27 #984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66683c3
fix(build): re-sign compiled macOS binary after bun compile
brianjfox Sep 13, 2026
38cf3d4
fix(release): fail smoke test on SIGKILLed binary
brianjfox Sep 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
},
"scripts": {
"build": "bun build ./src/index.ts --outdir ./dist --target bun --external '@opentui/core-*' && bun scripts/copy-repo-plugins.ts",
"build:bin": "bun build ./src/index.ts --compile --minify --define process.env.NODE_ENV='\"production\"' --outfile ./dist/corbits && bun scripts/copy-repo-plugins.ts",
"build:bin": "bun build ./src/index.ts --compile --minify --define process.env.NODE_ENV='\"production\"' --outfile ./dist/corbits && ([ \"$(uname -s)\" != Darwin ] || codesign -s - --force ./dist/corbits) && bun scripts/copy-repo-plugins.ts",
"typecheck": "tsc --noEmit",
"test": "bun test ./src ./tests ./evals ./scripts --randomize --seed 424242",
"test:paths": "bun scripts/test-paths.ts",
Expand Down
19 changes: 18 additions & 1 deletion scripts/release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,12 +137,27 @@ host_label() {
# node_modules; leaving it external makes first TUI load fail with
# "Cannot find package 'react-devtools-core'".
# Keep this block in sync with package.json "build:bin" when those flags change.
#
# macOS targets are ad-hoc re-signed after compile. `bun build --compile`
# appends the JS payload to Bun's linker-signed executable without re-signing
# it (oven-sh/bun#32159), so the embedded signature no longer matches the file
# and macOS 26+/27 SIGKILLs the binary at launch (exit 137, no output).
# `codesign` only exists on macOS hosts, which is where darwin releases are cut.
compile_bin() { # compile_bin BUN_TARGET OUTFILE
local target=$1 out=$2
bun build ./src/index.ts --compile --target="$target" --minify \
--define process.env.NODE_ENV='"production"' \
--define process.env.DEV='"false"' \
--outfile "$out" >/dev/null
case "$target" in
bun-darwin-*)
if command -v codesign >/dev/null 2>&1; then
codesign -s - --force "$out" >/dev/null 2>&1 \
|| die "codesign failed for $target ($out)"
else
info "warning: codesign not available; $target binary is not re-signed and will not launch on macOS 26+"
fi ;;
esac
}

# Smoke-test a freshly compiled native binary before packaging. Cross-compiled
Expand All @@ -161,7 +176,9 @@ smoke_bin() { # smoke_bin LABEL BINARY
local rc=0
"$bin" --__release_smoke__ >/dev/null 2>&1 || rc=$?
# 126 = cannot execute, 127 = not found — real link/exec failures.
if [ "$rc" -eq 126 ] || [ "$rc" -eq 127 ]; then
# 137 = SIGKILL before any code ran: on macOS that is the kernel rejecting an
# invalid code signature (see compile_bin), so the binary is dead on arrival.
if [ "$rc" -eq 126 ] || [ "$rc" -eq 127 ] || [ "$rc" -eq 137 ]; then
die "smoke: cannot execute $label binary (rc=$rc)"
fi
# Non-zero from "unrecognized flag" (or similar) still proves the binary ran.
Expand Down
Loading