docs(readme): Quickstart shows real host usage (CL-8775) - #48
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
installMemory, an exported function that mountscreateMemoryon a realHono<TenantEnv>app with a realGrantStore/ConditionRegistry, matching the memory mount in a production Interchange hub'sapps/hub/src/server.ts.mountWorkflowMemoryfor run-scoped routes, plus the migration step (runMemoryMigrations) before serving traffic.EMBED_BASE_URL/EMBED_MODELis a required pair (both or neither), no credential-based fallback — config is env-only, resolved once per process.createFakeDocumentStoreas if it were a real host's Quickstart path; the fake store is now only mentioned under Development as a test utility.Test plan
readme-check.tsat the repo root with a scratch tsconfig including it, ranbunx tsc --noEmit -p tsconfig.readme-check.json— clean, no errors. Scratch files deleted before commit.bun run typecheckpasses.npx prettier --write README.mdapplied (repo has no prettier config/script of its own; formatting matches the tool's defaults already used across the file).Follow-up
process.env.DATABASE_URL!, a non-null assertion. Replaced with a small exportedmigrateMemory(databaseUrl: string)and a fail-fast check onDATABASE_URLbefore calling it.