test: delete the arktype schema tests - #55
Open
TheGreatAxios wants to merge 2 commits into
Conversation
TheGreatAxios
commented
Sep 25, 2026
TheGreatAxios
left a comment
Contributor
Author
There was a problem hiding this comment.
Self-review, two passes.
Verdict: ready for review.
The branch only deletes tests. The SQL-versus-enum lockstep check stays, and the fakes are still used by the plane tests.
TheGreatAxios
force-pushed
the
cl-9105-memory-delete-arktype-schema-and-enum-lockstep-tests
branch
from
September 25, 2026 07:02
36ef00c to
aa979a3
Compare
TheGreatAxios
force-pushed
the
cl-9105-memory-delete-arktype-schema-and-enum-lockstep-tests
branch
from
September 25, 2026 18:31
aa979a3 to
a996a95
Compare
TheGreatAxios
force-pushed
the
cl-9105-memory-delete-arktype-schema-and-enum-lockstep-tests
branch
from
September 26, 2026 01:32
a996a95 to
245a0c1
Compare
The schema tests and the arktype half of the enum lockstep test assert that arktype validates what each schema declares, which tests the library rather than this package. The lockstep check that the migration CHECK constraints match the TypeScript enum constants stays.
These tests exercised the test doubles rather than production code.
TheGreatAxios
force-pushed
the
cl-9105-memory-delete-arktype-schema-and-enum-lockstep-tests
branch
from
September 26, 2026 01:36
245a0c1 to
efe3a46
Compare
TheGreatAxios
added this pull request to stack #61
September 26, 2026 01:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #54; merge that first.
src/core/schemas/*.test.ts) and the arktype half ofsrc/core/enums.lockstep.test.ts. They tested that arktype validates what each schema declares.src/ports/fakes.test.tsandsrc/ports/mount-fakes.test.ts, which tested the test doubles.Verification
bun run typecheckandbun test ./srcpass (418 tests).Closes CL-9105
Closes CL-9110