test: embed and rerank clients against a local HTTP server - #58
Merged
TheGreatAxios merged 1 commit intoSep 27, 2026
Conversation
TheGreatAxios
commented
Sep 25, 2026
TheGreatAxios
left a comment
Contributor
Author
There was a problem hiding this comment.
Self-review, three passes.
Verdict: ready for review.
- Every deleted case has an HTTP-level equivalent.
- The stub resets its reply and recorded requests between tests.
- The one waiver is listed in the description.
TheGreatAxios
force-pushed
the
cl-9127-memory-delete-mocked-embed-client-and-rerank-client-tests
branch
from
September 25, 2026 18:31
a5fbf41 to
174bb6f
Compare
TheGreatAxios
force-pushed
the
cl-9127-memory-delete-mocked-embed-client-and-rerank-client-tests
branch
2 times, most recently
from
September 26, 2026 00:53
665b84e to
6698c17
Compare
TheGreatAxios
force-pushed
the
cl-9127-memory-delete-mocked-embed-client-and-rerank-client-tests
branch
from
September 26, 2026 01:32
6698c17 to
1ccffbe
Compare
TheGreatAxios
force-pushed
the
cl-9127-memory-delete-mocked-embed-client-and-rerank-client-tests
branch
from
September 26, 2026 01:36
1ccffbe to
e45e5fd
Compare
TheGreatAxios
added this pull request to stack #61
September 26, 2026 01:57
The clients now send real requests to a Bun.serve stub instead of a mocked fetch, so each test checks the wire shape, headers and body the endpoint actually receives. The rerank config validation tests move with them.
TheGreatAxios
force-pushed
the
cl-9127-memory-delete-mocked-embed-client-and-rerank-client-tests
branch
from
September 27, 2026 00:32
e45e5fd to
a0f8a3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #57; merge that first.
src/core/embed-client.test.tsandsrc/core/rerank-client.test.ts, which asserted against a mockedfetch, are replaced bytests/embed-client.test.tsandtests/rerank-client.test.ts.Bun.servestub (tests/lib/http-stub.ts) and check the path, auth header and JSON body the endpoint receives.validateRerankConfigcases move with the rerank tests.test:coveragenow includes./tests.Verification
bun run typecheckpasses.bun run testpasses (411 pass; the Postgres suites skip withoutTEST_DATABASE_URL).Closes CL-9127