Frontend: do not return 500 if the user request cancellation.#2156
Merged
pracucci merged 5 commits intoFeb 19, 2020
Merged
Conversation
cyriltovena
force-pushed
the
context-cancellation-frontend
branch
from
February 18, 2020 21:11
743d45f to
f9cc565
Compare
tomwilkie
reviewed
Feb 19, 2020
pracucci
approved these changes
Feb 19, 2020
pracucci
left a comment
Contributor
There was a problem hiding this comment.
I'm in big favour of this change. Thanks for it! LGTM (after Tom's comment is addressed and PR rebased due to the conflict)
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
cyriltovena
force-pushed
the
context-cancellation-frontend
branch
from
February 19, 2020 13:55
e502429 to
8c68773
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com
As discussed with @pracucci , This change how the frontend handle cancellation/timeout.
If the user request/upstream cancellation, then we don't throw a 5xx but a 499 instead (I'm happy to choose another code).
However in case of deadline exceeded/timeout, or unknown error we're sending back a 500.
The reason for this change is because if a user quickly cancel a request (page refresh) before it has time to answer the frontend will register this as an error (500) which I don't think we should.