Track data selection time range in query stats independent of query priority and rejection#7724
Open
yeya24 wants to merge 2 commits into
Open
Track data selection time range in query stats independent of query priority and rejection#7724yeya24 wants to merge 2 commits into
yeya24 wants to merge 2 commits into
Conversation
…riority and rejection Previously, rejectQueryOrSetPriority returned early when both query priority and query rejection were disabled, so DataSelectMinTime and DataSelectMaxTime were never set in the request stats. Track the data selection time range for query and query_range requests regardless of whether query priority or query rejection is enabled. Fixes cortexproject#6484 Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Previously,
rejectQueryOrSetPriorityreturned early when both query priority and query rejection were disabled, soDataSelectMinTimeandDataSelectMaxTimewere never set in the request stats.This PR moves the data selection time range tracking before the enabled checks so it is always set for
queryandquery_rangerequests, regardless of whether query priority or query rejection is enabled. The min/max time is used by the query frontend handler for query stats logging (data_select_min_time/data_select_max_time).Which issue(s) this PR fixes:
Fixes #6484
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/updated with any needed changes (ranmake doc, no changes)