Repository navigation
License and v0.1.0 release prep - #4
Merged
Merged
Conversation
The Go sources already carried Apache-2.0 boilerplate headers from the kubebuilder scaffold, but a header is not a declared license — GitHub reported this repo as unlicensed, which blocks anyone vendoring the chart under their own Apache-2.0 terms. Add the standard, unmodified Apache License 2.0 text at the repo root and replace the placeholder "Copyright 2026." with a real holder in every source header and in hack/boilerplate.go.txt, so make generate keeps stamping the same holder on future files. Assisted-By: LLM Signed-off-by: Timofei Larkin <lllamnyp@gmail.com>
Cozystack's update target vendors chart/address-controller/ with a plain cp -r from the tagged commit, not through make helm-package, so the literal Chart.yaml version is what ends up in a downstream vendor tree. Replace the 0.0.0 placeholder with 0.1.0 to match appVersion and the upcoming v0.1.0 tag, and drop the now-stale comment pointing at package-time stamping. Assisted-By: LLM Signed-off-by: Timofei Larkin <lllamnyp@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepares this repo to be vendored as an upstream chart (per the Cozystack packaging handoff): a declared license and a deliberate chart version ahead of tagging
v0.1.0.What changed
LICENSE— the standard, unmodified Apache License 2.0 text at the repo root. The Go sources already carried Apache-2.0 header boilerplate, but GitHub reported no declared license, which blocks anyone vendoring the chart under Apache-2.0 terms of their own.Copyright 2026.placeholder withCopyright 2026 Timofei Larkinin every Go source header and inhack/boilerplate.go.txt, somake generatekeeps stamping the same holder on new generated files.zz_generated.deepcopy.gowas regenerated viamake generate, not hand-edited.chart/address-controller/Chart.yaml'sversionto0.1.0, replacing the0.0.0placeholder, to matchappVersionahead of thev0.1.0tag. Dropped the now-stale Makefile comment about package-time stamping.make manifests,go build ./..., andhelm lintall pass clean; no changes tocrds/ortemplates/role.yaml.Holder string flagged for review: headers now read
Copyright 2026 Timofei Larkin— correct me before merging if you'd rather it read differently (e.g. a different name form, or no year).