-
Notifications
You must be signed in to change notification settings - Fork 208
fix(extra): add the check-release-name guard to external-dns, gateway, info and seaweedfs #3371
Copy link
Copy link
Open
Labels
area/extraIssues or PRs related to tenant-specific modules (packages/extra/)Issues or PRs related to tenant-specific modules (packages/extra/)kind/cleanupCategorizes issue or PR as related to cleanup of code, process, or technical debtCategorizes issue or PR as related to cleanup of code, process, or technical debtpriority/backlogGeneral backlog priority. Lower than priority/important-longtermGeneral backlog priority. Lower than priority/important-longtermtriage/acceptedIndicates an issue is ready to be actively worked onIndicates an issue is ready to be actively worked on
Description
Activity
Metadata
Metadata
Assignees
Labels
area/extraIssues or PRs related to tenant-specific modules (packages/extra/)Issues or PRs related to tenant-specific modules (packages/extra/)kind/cleanupCategorizes issue or PR as related to cleanup of code, process, or technical debtCategorizes issue or PR as related to cleanup of code, process, or technical debtpriority/backlogGeneral backlog priority. Lower than priority/important-longtermGeneral backlog priority. Lower than priority/important-longtermtriage/acceptedIndicates an issue is ready to be actively worked onIndicates an issue is ready to be actively worked on
Follow-up from the #3280 review. Four of the nine
packages/extra/charts ship acheck-release-name.yamlguard that fails the render when the release name diverges from the chart name (bootbox,etcd,ingress,monitoring, and nowcomputeplane); the other four (external-dns,gateway,info,seaweedfs) do not, and carry the same latent exposure: a module installed under a non-canonical release name silently diverges from the object-name mapping the aggregated API assumes (release.prefix+ object name), which is how HelmRelease/Helm-storage collisions start.Adding the guard is a copy of the existing three-line template per chart plus a two-case unittest (see
packages/extra/computeplane/templates/check-release-name.yamlandtests/release_name_test.yamlfrom #3280).Note: cozystack/community#39 proposes
cardinalityas a declarative capability onApplicationDefinition, which would replace all of these hand-rolled per-chart guards — they should be understood as a stopgap until that lands.