docs(talm): document the ZFS export-on-shutdown knob - #721
Aleksei Sviridkin (lexfrei) wants to merge 1 commit into
Conversation
The cozystack preset now turns off the ZFS pool export at shutdown, which hangs a LINSTOR-on-ZFS node in rebooting while DRBD holds the zvols. Describe the zfs.exportOnShutdown knob, which disk layouts need the export back, the Talos version it depends on, and the one-time manual reboot a running cluster needs before the setting takes effect. Assisted-by: LLM Signed-off-by: Aleksei Sviridkin <f@lex.la>
✅ Deploy Preview for cozystack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
IvanHunters
left a comment
There was a problem hiding this comment.
Verdict
LGTM with non-blocking notes
Documentation is accurate and internally consistent: the new section nests correctly, both version paths (next and v1.6) receive identical content, the two to three tunable count is updated in both files with no stale reference left, all fenced blocks are closed, and the kubectl/cryptsetup command syntax is sound. Nothing blocks merge.
Caveats
- The dm-crypt close step (
cryptsetup close "$(cat /sys/block/dm-N/dm/name)") is disclosed in the PR body as not yet run on a live cluster. The command is syntactically correct, but the step is unverified end-to-end; worth a live run before relying on it in an incident. - The Talos version-behaviour claims (
ZFS_EXPORT_TIMEOUThonoured from v1.13.4; v1.13.0 to v1.13.3 always export; earlier never export) are author-asserted and were not independently verified against Talos source in this review. - The section is headed
Talm v0.36+, a release not yet cut; merging is correctly gated on that release per the PR description.
The talm page gets a section on the new cozystack preset setting that stops the ZFS extension from exporting the pool on shutdown. Without it, a node with LINSTOR on ZFS hangs in
rebootingon every reboot, upgrade and reset while DRBD holds its zvols (cozystack/cozystack#4597). The talm side is cozystack/talm#251.The section says which disk layouts need the export back and that the fix only works on Talos v1.13.4 or later. Most of the text is the one-time reboot for clusters that already run. The running
zfs-servicekeeps its old environment, so the first reboot after the change can still hang. The step that closes a dm-crypt mapping left by the LINSTOR LUKS layer has not been run on a live cluster yet.The satellite commands use
ds/linstor-satellite.<node>. Piraeus runs one DaemonSet per node, so thepod/linstor-satellite.<node>form used on other install pages does not resolve. I left those pages alone in this PR.The heading says Talm v0.36+, the next minor after v0.35.0, so this should merge once that release is out. Applied to
nextandv1.6.