fix: report package compatibility train policy - #1291
Conversation
|
Warning Review limit reached
Next review available in: 26 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthrough내부 ChangesCompatibility Train Policy & Reporting
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant CLI as package-quality-report CLI
participant Policy as internal-croco-compatibility-policy.mjs
participant CrocoRanges as croco-ranges.ts
participant Report as CompatibilityTrainReport
CLI->>Policy: readInternalPeerDependencyRangeExceptions
CLI->>CrocoRanges: getGeneratedAppCrocoVersionSet
CLI->>Report: 내부 range drift, peer 예외, 생성 앱 비교, fixed/linked 결정 종합
Report-->>CLI: pass/fail 상태 + 대시보드 마크다운
CLI->>CLI: status === "fail" 시 process.exit(1)
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 85fc67b837
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
📊 Benchmark Results✅ All benchmarks passed
Updated: 2026-07-07T02:42:41.932Z · Commit: 5e23e48 |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/create-croco-app/src/tests/croco-ranges.spec.ts`:
- Around line 48-65: `normalizeCatalogSpinePackageName` is duplicated across the
test and two script files, so the catalog naming rule can drift out of sync.
Extract this logic into a shared helper or export it from one existing location
and have `croco-ranges.spec.ts`, `scripts/alpha-release-smoke.mts`, and
`scripts/package-quality-report.mts` reuse that single implementation. Keep the
existing behavior for `create-croco-app` and scoped package names, and update
the call sites to import the shared symbol instead of redefining it.
In `@scripts/package-quality-report.mts`:
- Around line 1669-1678: `formatCompatibilityTrainPeerExceptionRows` is omitting
the `compatibilityRationale` field from the peer exception table. Update the row
rendering for `CompatibilityTrainReport.peerExceptions` to include
`exception.compatibilityRationale`, and make sure the matching table header in
the same report output also adds a `Compatibility rationale` column so the
rendered columns stay aligned.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: b684f19c-3caa-4f73-a009-bd95fb1ad6c7
📒 Files selected for processing (12)
.changeset/generated-app-compatibility-train.mdRELEASING.mddocs/release/croco-1.0-spine.mddocs/release/package-entrypoint-contract.mddocs/release/package-quality-dashboard.mdpackages/create-croco-app/src/helpers/croco-ranges.tspackages/create-croco-app/src/tests/croco-ranges.spec.tsscripts/internal-croco-compatibility-policy.mjsscripts/normalize-packages.mjsscripts/package-quality-report.mtsscripts/tests/normalize-packages.spec.tsscripts/tests/package-quality-report.spec.ts
Fixes #1227.
Summary
@croco/*ranges stay onworkspace:*except checked peer semver exceptions with reason, owner, and compatibility rationale.create-croco-appgenerated Croco version set and makespackage-quality:reportcompare template workspace rows, actual emitted semver ranges, and expected workspace package ranges.create-croco-app.Verification
pnpm package-manifests:checkpnpm exec vitest run scripts/tests/normalize-packages.spec.ts scripts/tests/package-quality-report.spec.ts --reporter=verbosepnpm --filter create-croco-app exec vitest run src/tests/croco-ranges.spec.ts --reporter=verbosepnpm package-quality:reportpnpm checkpnpm typecheckpnpm testpnpm --filter create-croco-app buildpnpm changeset-required:check -- --base origin/trunk --head HEADgit diff --checkauto-changeset, repo-widetest(225/225 Turbo tasks), and repo-widetypecheck(224/224 Turbo tasks).Self-review gates
generatedAppRangeDriftCount, and focused tests cover pass, stale-range failure, and legacy exception schema rejection.create-croco-appgets additive exported range-set metadata and a patch changeset; fixed/linked groups stay intentionally empty and documented.Review and QA
Summary by CodeRabbit
New Features
Bug Fixes
Documentation