fix: retain generated smoke failure artifacts in CI

[kang-heewon]

Summary

Generated-app smoke failure bundles are now available from CI as a dedicated artifact, including per-case captured output and selected generated files. The workflow contract also guards this retention path, and the smoke matrix assertion is type-safe under direct TypeScript checking.

Follow-up to #1241.

Verification

• pnpm vitest run scripts/tests/ci-workflow.spec.ts scripts/tests/create-croco-app-generated-smoke.spec.ts
• pnpm check
• Pre-push pnpm test and pnpm typecheck

Summary by CodeRabbit

• CI 개선

  • 생성된 앱 스모크 테스트 실패 시 관련 결과 파일을 자동으로 아티팩트로 업로드합니다.
  • 결과 파일이 없는 경우에도 CI가 불필요하게 실패하지 않습니다.

• 테스트

  • 실패 아티팩트 업로드 단계와 설정이 올바르게 적용되는지 검증합니다.
  • 스모크 테스트 케이스 정의 검증의 타입 안정성을 개선했습니다.

[coderabbitai]

Warning

Review limit reached

@kang-heewon, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 53 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 08f329b5-d229-487d-ab3c-9de8e9b9cc34

📥 Commits

Reviewing files that changed from the base of the PR and between ef7fced and 8291f88.

📒 Files selected for processing (3)

• .github/workflows/ci.yml
• scripts/tests/ci-workflow.spec.ts
• scripts/tests/create-croco-app-generated-smoke.spec.ts

📝 Walkthrough

Walkthrough

CI가 생성 앱 스모크 실패 케이스 리포트를 아티팩트로 업로드하도록 변경되었으며, 업로드 단계와 생성 스모크 매트릭스 관련 테스트가 갱신되었습니다.

Changes

생성 앱 스모크 아티팩트

Layer / File(s)	Summary
실패 아티팩트 업로드 .github/workflows/ci.yml	validate 잡이 항상 생성 앱 스모크 실패 리포트를 업로드하고, 파일이 없을 때는 무시합니다.
워크플로우 및 매트릭스 검증 scripts/tests/ci-workflow.spec.ts, scripts/tests/create-croco-app-generated-smoke.spec.ts	업로드 단계의 순서·경로·파일 없음 처리 설정을 검증하고, graphql-lambda-api 케이스 검색 결과에 SmokeMatrixCaseDefinition 타입을 적용합니다.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	CI에서 생성된 smoke 실패 아티팩트를 보존하도록 한 변경을 잘 요약한 제목입니다.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-1241-upload-smoke-failure-artifacts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ef7fceda9a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[github-actions]

📊 Benchmark Results

✅ All benchmarks passed

Benchmark	p75	Threshold	Baseline	vs Baseline	Status	Notes
CrocoApp constructor	9.2μs	30.0ms	8.2μs	+12.3%	✅	-
CrocoApp lambdaHandler (10 controllers)	282.8μs	50.0ms	258.4μs	+9.4%	✅	-
Lambda cold-start simulation	427.6μs	80.0ms	418.1μs	+2.3%	✅	-
Lambda cold-start with headers	385.6μs	80.0ms	369.7μs	+4.3%	✅	-
Lambda cold-start with binary body	383.4μs	80.0ms	339.1μs	+13.0%	✅	-
Lambda cold-start with query params	320.7μs	80.0ms	301.3μs	+6.4%	✅	-
Lambda cold-start with authorizer context	314.7μs	80.0ms	299.8μs	+5.0%	✅	-
Lambda cold-start realistic scenario	315.1μs	80.0ms	299.2μs	+5.3%	✅	-
EventBusConfig.start (10 handlers)	1.8μs	10.0ms	1.4μs	+28.3%	❌	-
EventPublisher.publishNow single event	2.0μs	2.0ms	1.7μs	+20.4%	❌	-
DefaultHandlerResolver.resolve × 10	0.1μs	5.0ms	0.1μs	-15.0%	✅	-
Container.get singleton (cold)	69.4μs	5.0ms	70.3μs	-1.2%	✅	-
Container.register × 50 components	3.4ms	10.0ms	3.2ms	+5.8%	✅	-
Container.validate (50 components)	3.9ms	20.0ms	3.4ms	+14.2%	✅	-
Container.get singleton (warm)	1.9μs	500.0μs	1.6μs	+15.7%	✅	-
TelemetryRuntime.init (lambda preset)	2.0μs	200.0ms	1.1ms	-99.8%	✅	-
lambdaPreset config creation	1.4μs	2.0ms	1.4μs	-3.9%	✅	-

_{Updated: 2026-07-11T00:16:06.145Z · Commit: ddf4d73}