fix: make the public SaaS scaffold journey executable - #1330
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (20)
📝 WalkthroughWalkthroughcreate-croco-app의 실제 CLI 계약을 분리하고, canonical ChangesCanonical SaaS first-success
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant FirstSuccessVerify
participant CreateCrocoAppProgram
participant Generator
participant GeneratedSaasWorkspace
participant DocsContractValidator
FirstSuccessVerify->>CreateCrocoAppProgram: documented command 파싱
CreateCrocoAppProgram->>Generator: 옵션 정규화 및 생성
Generator->>GeneratedSaasWorkspace: SaaS manifest, routes, README 생성
FirstSuccessVerify->>DocsContractValidator: 생성물 및 문서 계약 검증
DocsContractValidator-->>FirstSuccessVerify: 실패 메시지 반환
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📊 Benchmark Results✅ All benchmarks passed
Updated: 2026-07-11T16:09:22.241Z · Commit: 0b334dc |
kang-heewon
force-pushed
the
fix/1313-first-success-journey
branch
from
July 11, 2026 16:01
204e658 to
9354fe8
Compare
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1313.
Summary
demo:smokesuccess state.Verification
pnpm test— 225/225 tasks passed.pnpm typecheck— 224/224 tasks passed.pnpm check— passed.pnpm first-success:verify— passed.pnpm create-croco-app:smoke— all 16 cases passed.pnpm alpha-release:smoke— packed production-app and canonical SaaS cases passed.pnpm changeset-required:check— passed.Self-review
Review and QA
Residual risk
pnpm create,pnpm dlx, and direct executable launcher extraction branches are not individually mutation-tested. All current public commands use the verifiednpxform.Summary by CodeRabbit
새 기능
saas-api목표로 REST SaaS 프로젝트를 생성하고, 외부 자격 증명 없이 데모 스모크 테스트를 실행할 수 있습니다.문서
버그 수정 및 검증