fix: create OpenAPI output directories predictably - #1748
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughOpenAPI CLI가 쓰기 모드에서 출력 파일의 상위 디렉터리를 생성합니다. ChangesOpenAPI 출력 경로 처리
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📊 Benchmark Results✅ All benchmarks passed
Updated: 2026-08-05T13:07:29.363Z · Commit: e5c2db0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
The OpenAPI CLI now creates missing parent directories before writing generated output, so clean nested targets such as
generated/contracts/openapi.jsonsucceed.--output-checkremains read-only and reports missing output without creating directories, while write failures preserve their original filesystem diagnostics.Fixes #1714
Verification
pnpm --filter @croco/openapi-spec test— 65 tests passed.pnpm --filter @croco/openapi-spec typecheck,lint, andbuild— passed.pnpm check— 24/25 repository gates passed; 1 not applicable; 0 failed.pnpm changeset-required:check -- --base origin/trunk --head HEAD— passed.Review gates
ENOENTbefore the change and now writes parseable OpenAPI from a clean directory; missing-output check coverage proves no parent directory is created, and anENOSPCfixture proves write diagnostics are preserved.@croco/openapi-spec.dirname(outFile)beforewriteFile, reusing Node filesystem primitives without new abstractions.Residual risk
None identified within the issue scope.
Summary by CodeRabbit
개선 사항
테스트