fix: declare transports-http zod dependency - #719
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
📝 WalkthroughWalkthrough
Changeszod 직접 의존성 선언 및 검증
예상 코드 리뷰 난이도🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📊 Benchmark Results✅ All benchmarks passed
Updated: 2026-06-14T16:47:15.963Z · Commit: 76fb6a9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@croco/transports-httpnow declareszodas a direct runtime dependency, so the package manifest matches the exported/source ParamResolver type surface instead of relying on transitive resolution through other Croco packages.Fixes #699
변경 사항
zodto@croco/transports-httpdependencies using the same^3.23.8range as the REST protocol packages.zoddependency.Verification
pnpm --filter @croco/transports-http exec vitest run src/tests/PackageManifest.spec.ts src/tests/ParamResolver.spec.ts src/tests/FrameworkIntegration.spec.ts(9 tests)pnpm build --filter=@croco/transports-http...(10 packages)pnpm typecheck --filter=@croco/transports-http(20 tasks)pnpm test --filter=@croco/transports-http(16 files, 101 tests)pnpm checkgit diff --check --cachedpnpm exec changeset status --since origin/trunk(patch bump includes@croco/transports-httpand fixed dependents)pnpm --filter @croco/transports-http pack --pack-destination /tmp/croco-transports-http-pack-smokeand tarball manifest check confirmeddependencies.zod === "^3.23.8"auto-changeset, fullpnpm test(195 tasks), fullpnpm typecheck(194 tasks)Self-review
zoddependency.Risk
Low. The change adds a dependency already used across adjacent protocol packages; package managers may install an explicit
zod@3.xfor@croco/transports-httpinstead of relying on transitive workspace resolution.Summary by CodeRabbit
릴리스 노트
버그 수정
테스트