fix: publish storage package root entrypoints - #772
Conversation
|
Warning Review limit reached
More reviews will be available in 53 minutes and 6 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (7)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
31bb838 to
26bbfac
Compare
Fixes #578.
Summary
@croco/storage-core,@croco/storage-cloudinary, and@croco/storage-r2now publish package-root entrypoints that point directly at shippeddistfiles. The package manifest normalizer also treats these storage packages as direct-dist entrypoint packages, so future root drift back tosrcfails manifest validation.변경 사항
main,module,types,exports, andpublishConfig.exportson the samedistentrypoints.srcroot drift.Verification
pnpm exec vitest run scripts/tests/normalize-packages.spec.ts --reporter verbose- passed, 9 tests.pnpm package-manifests:check- passed, 97 checked / 2 private skipped.pnpm build- passed, 99 tasks.pnpm package-entrypoints:smoke- passed, 96 public packages; storage-core, storage-cloudinary, and storage-r2 resolved through CJS, ESM, and TypeScript consumers.@croco/storage-core,@croco/storage-cloudinary, and@croco/storage-r2- passed; each tarball root manifest pointsmain/module/types/exportsatdist, includesdist/index.{js,mjs,d.ts}, and excludessrc/index.ts.pnpm check- passed.pnpm test- passed, 197 tasks.pnpm typecheck- passed, 196 tasks.git diff --check origin/trunk...HEAD- passed.test, and full cachedtypecheckpassed.Self-review
srcroot entrypoints for the storage packages, manifest normalization, dry-pack tarball inspection, and package-entrypoint smoke coverage.distartifacts for CJS, ESM, and types; no dependencies, lockfile entries, secrets, or environment assumptions changed; patch changesets cover the three publishable packages.Risk
Low. Package-root imports now require built
distartifacts, which matches the published package shape and the repo's Turbo build/test/typecheck dependency graph.