Skip to content

Update compile SDK from 29 (Android 10) to 30 (Android 11) - #444

Merged
oliverlockwood merged 4 commits into
masterfrom
update-compile-sdk-to-android-11
Oct 8, 2020
Merged

Update compile SDK from 29 (Android 10) to 30 (Android 11)#444
oliverlockwood merged 4 commits into
masterfrom
update-compile-sdk-to-android-11

Conversation

@oliverlockwood

Copy link
Copy Markdown
Member

Based on https://developer.android.com/about/versions/11/behavior-changes-all I think this should be fine (we've already improved our approach around permissions in a relevant way).

Based on https://developer.android.com/about/versions/11/behavior-changes-11 I am not yet upgrading the target SDK - since I think the statement of:

Scoped storage enforcement: Access into external storage directories is limited to an app-specific directory and specific types of media that the app has created.

has a potential impact until Jez's work on the offline mapping download has been completed.

@jezhiggins @mvl22 @HilaryN please review.

@jezhiggins

Copy link
Copy Markdown
Member

The scoped file access is already in hand, so there's no need to hold back because of that.

@oliverlockwood

Copy link
Copy Markdown
Member Author

The scoped file access is already in hand, so there's no need to hold back because of that.

As in, already merged in, or already in your PR which is outstanding?

@jezhiggins

Copy link
Copy Markdown
Member

In the outstanding PR.

@HilaryN

HilaryN commented Oct 4, 2020

Copy link
Copy Markdown
Contributor

Looks good to me. Not sure if it's a relevant test but I quickly checked voice nav works when screen locked for Android 11, 10 and 9 emulators.

@oliverlockwood

Copy link
Copy Markdown
Member Author

On that basis @jezhiggins I'll keep that change out of this PR, so we can merge this in without waiting for yours to be ready. I've raised #445 and #446 to track the outstanding dependency upgrade bits; if you would be so kind to review as it stands, that'd be great.

@oliverlockwood
oliverlockwood merged commit 45a040d into master Oct 8, 2020
@oliverlockwood
oliverlockwood deleted the update-compile-sdk-to-android-11 branch October 8, 2020 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants