人気ルームの一覧を作る - #264
Merged
Merged
Conversation
chigichan24
requested changes
May 9, 2018
| .map { convertToViewModel(it) } | ||
| .observeOn(AndroidSchedulers.mainThread()) | ||
| .subscribe({ response -> | ||
| response.forEachIndexed { index, viewModel -> |
| response.forEachIndexed { index, viewModel -> | ||
| when (index) { | ||
| in 0..(this.roomViewModels.size - 1) -> | ||
| if (isChanged(this.roomViewModels[index], viewModel)) { |
Member
There was a problem hiding this comment.
private fun isChanged() 使わなくなってるはずなんで消してくださいー
| .observeOn(AndroidSchedulers.mainThread()) | ||
| ) | ||
| .subscribe({ | ||
| it.first.run { |
Member
There was a problem hiding this comment.
it.firstとit.second可能なら意味の分かる名前で置いて処理してほしい．
| binding.joinedRoomRecycler.adapter = adapter | ||
| binding.joinedRoomRecycler.layoutManager = LinearLayoutManager(this) | ||
| binding.joinedRoomRecycler.run { | ||
| this.isNestedScrollingEnabled = false |
| val result: String, | ||
| val user: User?, | ||
| val room: Room?, | ||
| val rooms: List<Room>?, |
Member
There was a problem hiding this comment.
roomsはserializedNameに入れてもう少し中身が分かるプロパティ名にしません？roomsだと，なんかjoined_rooms \sunseteq rooms みたいな印象を与える．
added 2 commits
May 12, 2018 14:49
chigichan24
approved these changes
May 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #260
DiffUtilをいい感じにするとより良い感じになるはず