This repository was archived by the owner on Nov 19, 2025. It is now read-only.
adds label rotation method - #59
Merged
Merged
Conversation
davelandry
suggested changes
May 14, 2018
| } | ||
| } | ||
| } | ||
| else if (horizontal) this._rotateLabels = this._labelRotation; |
Member
There was a problem hiding this comment.
Is this this._rotateLabels variable used in any other files/functions? If not, why not just make it a local variable (not attached to this).
| const labelHeight = max(textData, t => t.height) || 0; | ||
|
|
||
| if (horizontal) { | ||
| if (horizontal && typeof this._labelRotation === "undefined") { |
Member
There was a problem hiding this comment.
Set this._labelRotate = true; in the constructor, so then you don't need to check for undefined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(closes #53 )
Description
.labelOffset()would returnthis._labelsorientistopby setting thetextAnchortostartwhen theorientistopand correctingy-positioncalculationTypes of changes
Checklist