fix(sidecar): non-interactive-safe frozen filtered install (confirmModulesPurge=false) - #824
Merged
Merged
Conversation
… under pnpm 10.34.5
The pnpm-era base-gate from main exposed a latent wall in fresh checkouts:
the start script's prestart chain died because pnpm 10.34.5 stops a
FILTERED install to ask about module state outside the filter ('If you
are running pnpm in CI ... set confirmModulesPurge to false'), and the
non-interactive child refuses with exit 1 — the source-runtime start-script
lane then timed out its 30s health window (reproduced: 30.1s fail in a
fresh checkout; the prestart alone fails in 2s with the purge prompt).
--config.confirmModulesPurge=false means 'proceed WITHOUT purging modules
outside the filter' — exactly the bootstrap's intent (it never prunes the
root tree). Proof, fresh checkout at origin/main: with the flag the cold
filtered install completes (16.4s) and the root node_modules stays intact;
the start-script lane passes warm in 3.1s and from a fully cold readiness
state (record + sidecar tree deleted) in 22.6s, inside the 30s window.
The warm main checkout was never affected (verify-only prestart).
Red/green: the ensure-claude-sidecar argv contract was updated first and
failed 6 tests against the old args; green 7/7 after the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The first pnpm-era
base-gate.sh testfrom main exposed a latent wall in fresh checkouts: the start script's prestart chain died because pnpm 10.34.5 stops a FILTERED install to ask about module state outside the filter ("If you are running pnpm in CI … set confirmModulesPurge to 'false'"), and the non-interactive child refuses with exit 1 — the source-runtime start-script lane then timed out its 30s health window.--config.confirmModulesPurge=falsemeans "proceed WITHOUT purging modules outside the filter" — exactly the bootstrap's intent (it never prunes the root tree).Verification
prepare:rust-runtimealone failed in 2s with the purge prompt.node_modulesintact (no purge); the start-script lane passes warm in 3.1s and from a fully cold readiness state (record + sidecar tree deleted) in 22.6s — inside the 30s window.in_tui_fork_rebinds_the_pane_identity— kata freshell#b46d, not addressed by this PR).