Skip to content

feat: add scopes support to Testcontainers Subscription - #1819

Merged
javier-aliaga merged 1 commit into
dapr:masterfrom
matheusandre1:issue1491
Oct 2, 2026
Merged

javier-aliaga merged 1 commit into
dapr:masterfrom
matheusandre1:issue1491

Conversation

@matheusandre1

Copy link
Copy Markdown
Contributor

Description

Adds support for scopes on programmatic subscriptions registered via Testcontainers (DaprContainer.withSubscription(...)).

Issue reference

Usage:

new DaprContainer(DAPR_RUNTIME_IMAGE_TAG)
    .withSubscription(new Subscription("my-sub", "pubsub", "topic", "/events", List.of("app1", "app2")));
apiVersion: dapr.io/v1alpha1
kind: Subscription
metadata:
  name: my-sub
spec:
  pubsubname: pubsub
  topic: topic
  route: /events
scopes:
- app1
- app2

Closes: #1491

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@matheusandre1
matheusandre1 force-pushed the issue1491 branch 2 times, most recently from aefd8f1 to ca6cb7e Compare October 1, 2026 16:15
Signed-off-by: Matheus André <matheusandr2@gmail.com>
@matheusandre1
matheusandre1 marked this pull request as ready for review October 1, 2026 16:45
@matheusandre1
matheusandre1 requested review from a team as code owners October 1, 2026 16:45
@codecov

codecov Bot commented Oct 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.11%. Comparing base (d5c3c62) to head (ce63ef7).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1819      +/-   ##
============================================
+ Coverage     78.99%   79.11%   +0.11%     
- Complexity     2591     2604      +13     
============================================
  Files           264      264              
  Lines          7770     7785      +15     
  Branches        815      820       +5     
============================================
+ Hits           6138     6159      +21     
+ Misses         1269     1266       -3     
+ Partials        363      360       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@javier-aliaga
javier-aliaga merged commit 13feb26 into dapr:master Oct 2, 2026
23 of 25 checks passed
@matheusandre1
matheusandre1 deleted the issue1491 branch October 2, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Dapr Testcontainers Subscription scopes

2 participants