V0.12.0.x [build] fix deprecated download paths - #1219
Merged
Conversation
UdjinM6
approved these changes
Dec 21, 2016
UdjinM6
left a comment
There was a problem hiding this comment.
both checks failed for win64 with
Program: Z:\home\travis\build\dashpay\dash\dash-x86_64-w64-mingw32\src\test\test_dash.exe
File: random.cpp, Line 89
which is "assert" line here:
void GetRandBytes(unsigned char* buf, int num)
{
if (RAND_bytes(buf, num) != 1) {
LogPrintf("%s: OpenSSL RAND_bytes() failed with error: %s\n", __func__, ERR_error_string(ERR_get_error(), NULL));
assert(false);
}
}
i.e smth wrong with openssl.
On another note all other jobs in travis builds succeeded 👍
utACK
Author
|
Maybe backporting this will fix it? |
|
There is a fallback to OS RNG in btc 0.13 which we don't have and most likely there are also some other changes related to this, so I wouldn't mess with that too much tbh. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some download paths have changed for (old) dependencies - fixed