Fixes inaccurate round count in CoinControlDialog (Issue #2068)

[PastaPastaPasta]

The CoinControlDialog previously displayed either the actual round count, or the maxRounds set through the options, whichever is lower (used GetOutputPrivateSendRounds). However, there is no reason why the CoinControlDialog should not always display the actual round count of an input (using GetRealOutputPrivateSendRounds). Since GetOutputPrivateSendRounds is defined as:

    int realPrivateSendRounds = GetRealOutpointPrivateSendRounds(outpoint, 0);
    return realPrivateSendRounds > privateSendClient.nPrivateSendRounds ? privateSendClient.nPrivateSendRounds : realPrivateSendRounds;

This should not break anything, while making it a little bit better and more accurate. Fixes #2068

[UdjinM6]

You are fixing it in the wrong place, should be the one in CoinControlDialog::updateView(). And ironically, it does break the build - there is a second argument there that you missed.

Anyway, I'm not convinced that #2068 is really an issue in the first place, so postponing this till 12.4 for now.

[PastaPastaPasta]

Yup, you're 100% right... That's what I get for not paying enough attention. Just updated that. I remember in my testing before that I was surprised that there wasn't a function where the second arg was assumed to be 0 if nothing was passed.

12.4 is fine, not a major change by any regard, but good in general as it makes it more accurate.

[UdjinM6]

Needs rebase after #2149

[PastaPastaPasta]

I was having difficulties, but was able to figure it out, I think... Please ended up doing git rebase upstream/develop -ff and then resolving the conflicts and then git push -f

Seems to be correct. Is this how I should have done it @UdjinM6 ?

[UdjinM6]

I usually rebase like this:

git checkout develop
git pull
git checkout mybranch
git rebase -i develop
git mergetool
<fix conflicts>
git rebase --contunue
git push MyRepo HEAD -f

Anyway, looks good imo.

ACK