Fix filtering of the lock votes for SPV nodes. - #2468
Merged
Conversation
Author
|
Don't merge it, please, looks like there is one more issue with this functionality. |
Author
|
Fixed, re-review, please. |
PastaPastaPasta
requested changes
Nov 21, 2018
PastaPastaPasta
left a comment
Member
There was a problem hiding this comment.
if statements should either have their bodies enclosed by brackets or on the same line
Co-Authored-By: gladcow <sergey@dash.org>
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Jun 29, 2020
* check request is not empty to use it for filtering * Filter vote INVs by tx hash * fix lock requests filtering * Apply suggestions from code review Co-Authored-By: gladcow <sergey@dash.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for functionality from #2184.
This fix allows to filter lock vote INV messages by the related transaction hash in the cases when we have failed to find related transaction itself. Node filter is not updated for transaction data (outputs, prevouts, etc.) in this case, but I think it doesn't matter, because it should be updated during other transaction related messages relay (lock requests or tx INV, for example).
Also, separate filtering is added for lock requests, because lock requests relay differs from simple tx relay and bloom filters were not really used for lock requests.