Update immer to ed9bdae5ad174bd6248383cce8c5c135fec7ff82 - #2625
Closed
UdjinM6 wants to merge 1 commit into
Closed
Conversation
|
Cool, someone (maybe the same person) reported the same issue to me. Will review the changes on Monday. For the backporting to v13, I'd suggest to only backport arximboldi/immer@dcb9823 instead of directly going to master, as I feel the risk of this would otherwise be too high so shortly before release. |
Author
|
The problem with backporting arximboldi/immer@dcb9823 is that it's in our current develop/0.13.0.x already :) |
Author
|
This one arximboldi/immer@c89819d looks like a good candidate though. At least bumping to it fixes the issue too and changes seems to be pretty small, see #2626 |
|
I can confirm that this commit resolves issue that i've reported. GJ |
Author
|
Will be superseded by #2630 , closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had a report that dashd crashes on FreeBSD due to a bug in immer. Bumping it to latest master fixes the issue.
This should be backported to 0.13.
EDIT: fyi, here is the script to build Dash Core on FreeBSD https://gist.github.com/UdjinM6/9242ab97fb819b77d07fbcbdcc074969 might be a good start for corresponding doc update ;)