Skip to content

Tighten rules for DSVIN/DSTX - #2897

Merged
UdjinM6 merged 8 commits into
dashpay:developfrom
UdjinM6:tightenpsrules
May 23, 2019
Merged

Tighten rules for DSVIN/DSTX#2897
UdjinM6 merged 8 commits into
dashpay:developfrom
UdjinM6:tightenpsrules

Conversation

@UdjinM6

@UdjinM6 UdjinM6 commented May 2, 2019

Copy link
Copy Markdown

No description provided.

Comment thread src/privatesend-server.cpp Outdated
@nmarley

nmarley commented May 6, 2019

Copy link
Copy Markdown

Just curious -- any specific reason consumeCollateral is a lambda instead of a regular function? Or just simpler since it's only called in CPrivateSendServer::ProcessMessage scope?

@UdjinM6

UdjinM6 commented May 6, 2019

Copy link
Copy Markdown
Author

@nmarley That's a good point, we can reuse it in a couple of other places actually. Fixed.

@UdjinM6 UdjinM6 added this to the 14.1 milestone May 10, 2019
Comment thread src/privatesend-server.cpp Outdated
Comment thread src/privatesend.cpp Outdated

@PastaPastaPasta PastaPastaPasta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6

UdjinM6 commented May 22, 2019

Copy link
Copy Markdown
Author

Rebased to fix log category after #2918

@PastaPastaPasta PastaPastaPasta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@codablock codablock left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6
UdjinM6 merged commit c08e761 into dashpay:develop May 23, 2019
@UdjinM6
UdjinM6 deleted the tightenpsrules branch November 26, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants