Skip to content

Implement rawchainlocksig and rawtxlocksig - #2930

Merged
UdjinM6 merged 4 commits into
dashpay:developfrom
UdjinM6:zmqrawsig
May 23, 2019
Merged

Implement rawchainlocksig and rawtxlocksig#2930
UdjinM6 merged 4 commits into
dashpay:developfrom
UdjinM6:zmqrawsig

Conversation

@UdjinM6

@UdjinM6 UdjinM6 commented May 21, 2019

Copy link
Copy Markdown

Pushes both the raw data and clsig/islock (respectively) in one message.

@UdjinM6 UdjinM6 added this to the 14.1 milestone May 21, 2019
@thephez

thephez commented May 21, 2019

Copy link
Copy Markdown
Collaborator

The PR title is a little redundant 😉

@UdjinM6 UdjinM6 changed the title Implement rawchainlocksig and rawchainlocksig Implement rawchainlocksig and rawtxlocksig May 21, 2019
PastaPastaPasta
PastaPastaPasta previously approved these changes May 21, 2019
View reviewed changes

@PastaPastaPasta PastaPastaPasta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@codablock

codablock commented May 22, 2019

Copy link
Copy Markdown

Not sure I like the name rawtxlocksig as all code refers to the locks as islock due to InstantSend

@PastaPastaPasta

PastaPastaPasta commented May 22, 2019

Copy link
Copy Markdown
Member

I agree with codablock on that point

@UdjinM6

UdjinM6 commented May 22, 2019

Copy link
Copy Markdown
Author

I'm not very happy with this either but rawtxlockislock looks even worse imo and I was trying to keep them at least somewhat consistent with each other. Probably dash-specific zmq messages should be revised at some point (e.g. rawtxlock pushes locked tx not the lock itself, should be rawlockedtx for example, same for rawchainlock -> rawlockedblock etc. and then these *sig messages could be deprecated and superseded by rawlockedtxsig and rawlockedblocksig for example).

codablock
codablock previously approved these changes May 22, 2019
View reviewed changes

@codablock codablock left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I think I understand the issue, so: utACK

@UdjinM6

UdjinM6 commented May 22, 2019

Copy link
Copy Markdown
Author

Rebased to fix log category after #2918

codablock
codablock approved these changes May 23, 2019
View reviewed changes

@codablock codablock left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK

@UdjinM6
UdjinM6 merged commit 428f304 into dashpay:develop May 23, 2019
@UdjinM6 UdjinM6 mentioned this pull request Sep 18, 2020
Open
@UdjinM6
UdjinM6 deleted the zmqrawsig branch November 26, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PastaPastaPasta PastaPastaPasta PastaPastaPasta left review comments
+1 more reviewer
@codablock codablock codablock approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

15

Development

Successfully merging this pull request may close these issues.

4 participants

@UdjinM6 @thephez @codablock @PastaPastaPasta