Skip to content

qt: Finetune Options Dialog - #3709

Merged
UdjinM6 merged 7 commits into
dashpay:developfrom
UdjinM6:finetuneoptionsdialog
Sep 18, 2020
Merged

UdjinM6 merged 7 commits into
dashpay:developfrom
UdjinM6:finetuneoptionsdialog

Conversation

@UdjinM6

@UdjinM6 UdjinM6 commented Sep 14, 2020

Copy link
Copy Markdown
Before After
Screenshot 2020-09-15 at 00 49 29 Screenshot 2020-09-15 at 00 49 03

Note: you can't see it on screenshots here but the long translation of the connectSocksTor checkbox text (e.g. in ru) also caused dialog resizing for bigger fonts (in case you are wondering why this one was tweaked too :) )

EDIT:
With this PR if a translation of the connectSocksTor checkbox is too long it's simply clipped
Screenshot 2020-09-15 at 01 14 43
but you can see the whole text if you resize the dialog manually
Screenshot 2020-09-15 at 01 15 19
Basically, it's a sign that translation should be shortened somehow but it at least doesn't cause resizing issues like it does currently.

EDIT2: This PR also removes Window tab and moves all its options into Main tab, see #3709 (comment) for screenshots.

@UdjinM6 UdjinM6 added this to the 16 milestone Sep 14, 2020
@UdjinM6

UdjinM6 commented Sep 15, 2020

Copy link
Copy Markdown
Author

One more tweak, thanks @xdustinface for the idea 👍

Main Window
Before 86f79f5 Screenshot 2020-09-15 at 03 40 36 Screenshot 2020-09-15 at 03 40 44
After 86f79f5 Screenshot 2020-09-15 at 03 40 20

(I disabled some code to make screenshots, there were no Window tab and there are no new options on Main tab on mac after the change)

@xdustinface

Copy link
Copy Markdown

Hmm im not really a fan of giving the dialog such a huge min-width.. adds a lot unused space if the translations aren't that long and font size is normal. What about clearing the checkboxes texts, place a normal label right besides them and put the text in there + activate wordWrap for the labels?

@UdjinM6

UdjinM6 commented Sep 15, 2020

Copy link
Copy Markdown
Author

@xdustinface how about 6ce7634?

EDIT: re "empty" checkboxes: I'd try to avoid hacks like that tbh

@xdustinface

Copy link
Copy Markdown

EDIT: re "empty" checkboxes: I'd try to avoid hacks like that tbh

Yeah also not the biggest fan but if they don't give the checkbox wordWrap 🤷‍♂️ Other things just coming in my mind are either to resize the window when it gets opened with QFontMetrics based on the widest text in the dialog or just create a simple custom checkbox widget with a button for the checkbox and a label with wordwrap for the text and just use it all over the place in the UI.

Anyway, im good with 6ce7634 if you don't want to spend more time on this 👍

@xdustinface

Copy link
Copy Markdown

One more for here: Thoughts about 5d3b1e2 i.e. dropping the surrounding "Expert" QGroupBox in Options -> Wallet to make the wallet tab consistent with the others? The "Expert" title isn't really needed, is it?

@UdjinM6

UdjinM6 commented Sep 17, 2020

Copy link
Copy Markdown
Author

Agree, this looks better 👍 Added.

@xdustinface xdustinface left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@PastaPastaPasta PastaPastaPasta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, looks good, however, please update the PR description to match new changes

@UdjinM6
UdjinM6 merged commit 18cfcbf into dashpay:develop Sep 18, 2020
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Sep 24, 2020
* Fix proxy port ui elements

* Fix fake net checkboxes

* Fix active options label by enabling text wrapping

* Fix options dialog resizing when font size is changed

* Move "Window" tab options into "Main" tab, drop "Window" tab

* Shrink min sizes a bit

* qt: Drop the surrounding QGroupBox in Options -> Wallet

Co-authored-by: xdustinface <xdustinfacex@gmail.com>
@UdjinM6
UdjinM6 deleted the finetuneoptionsdialog branch November 26, 2020 13:26
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Mar 8, 2022
* Fix proxy port ui elements

* Fix fake net checkboxes

* Fix active options label by enabling text wrapping

* Fix options dialog resizing when font size is changed

* Move "Window" tab options into "Main" tab, drop "Window" tab

* Shrink min sizes a bit

* qt: Drop the surrounding QGroupBox in Options -> Wallet

Co-authored-by: xdustinface <xdustinfacex@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants