qt: Fix font family updates - #3746
Merged
UdjinM6 merged 3 commits intoSep 29, 2020
Merged
Conversation
Author
|
Wait ... Recent transactions on the overview still don't react to family changes. Thats really the last one now... 🙈 Testing here.. pushing in few minutes. |
Introduced because QListView is ignored in GUIUtil::updateFonts, so its base font family doesn't change, hence the recent transactions don't adjust because the painter's font doesn't change.
xdustinface
dismissed stale reviews from PastaPastaPasta and UdjinM6
via
September 29, 2020 00:33
824281e
|
I think you need smth like b3e9da9535 cause otherwise you draw both lines with the same font size actually |
UdjinM6
approved these changes
Sep 29, 2020
UdjinM6
left a comment
There was a problem hiding this comment.
Seems to be working as expected now 👍
re-ACK
xdustinface
added a commit
to xdustinface/dash
that referenced
this pull request
Sep 29, 2020
* qt: Update the application font if the font family gets changed * qt: Make sure recent transactions have the correct font family Introduced because QListView is ignored in GUIUtil::updateFonts, so its base font family doesn't change, hence the recent transactions don't adjust because the painter's font doesn't change. * Store initial font size
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Mar 10, 2022
* qt: Update the application font if the font family gets changed * qt: Make sure recent transactions have the correct font family Introduced because QListView is ignored in GUIUtil::updateFonts, so its base font family doesn't change, hence the recent transactions don't adjust because the painter's font doesn't change. * Store initial font size Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required now after the
GUIUtil::setApplicationFont()call was removed fromGUIUtil::updateFonts()andQListViewis getting ignored byGUIUtil::updateFonts()both introduced in #3734.