trivial: remove unneeded header, enumerate circular dependencies - #5941
Merged
Merged
Conversation
As found in a review comment in dashpay#5908[1], validation.h is not needed for specialtxman.cpp and removing the header uncovers other circular dependencies that were obscured by the shortest circular path[2]. [1] - dashpay#5929 (comment) [2] - dashpay#5929 (comment)
5 tasks
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
May 8, 2026
036d7ea doc: Correct description of CAddrMan::Create() (Amiti Uttarwar) 318176a doc: Update high-level addrman description (Martin Zumsande) Pull request description: The high-level description of `addrman` has outdated information with respect to the eviction behavior, both for the New and Tried tables (at least since dashpay#5941) - this has confused me in the past. This PR corrects this and also adds basic info about the bucket size and position. ACKs for top commit: amitiuttarwar: reACK 036d7ea jnewbery: ACK 036d7ea Tree-SHA512: 3f0635d765f5e580a1fae31187742a833cef66ef2286d40eeb28f2253521260038e16e5f1a65741464a2ddfdbeb5c0f1bc38bf73841e600639033d59c3c534e4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional Information
As found in #5929 (comment),
validation.his not needed forspecialtxman.cppand removing the header uncovers other circular dependencies that were obscured by the shortest circular path (see #5929 (comment)).Breaking Changes
None.
Checklist: