fix: missing lock cs_wallet in rpc/evo - #6002
Merged
Merged
Conversation
It also reduce scope of both locks
knst
marked this pull request as ready for review
May 2, 2024 18:32
knst
requested review from
PastaPastaPasta and
UdjinM6
and removed request for
UdjinM6
May 2, 2024 18:32
UdjinM6
reviewed
May 2, 2024
PastaPastaPasta
approved these changes
May 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Changing order of locking
cs_mainandcs_walletto prevent a deadlock.There's call
protx_list->BuildDMNListEntry->CheckWalletOwnsScript:It can cause a deadlock due to wrong order of locks (cs_wallet supposed to be blocked in prior of cs_main)
What was done?
This PR adds and extra lock of cs_wallet and reduce scope of cs_main for a bit
How Has This Been Tested?
Deadlock warning is reproduced with this PR: #6003
Breaking Changes
N/A
Checklist: