Skip to content

perf: versionbits avoid calculation which is not used #6632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PastaPastaPasta merged 1 commit into from
Apr 28, 2025
Merged

perf: versionbits avoid calculation which is not used #6632

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/versionbits.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,9 @@ ThresholdState AbstractThresholdConditionChecker::GetStateFor(const CBlockIndex*
assert(cache.count(pindexPrev));
ThresholdState state = cache[pindexPrev];

// we should avoid heavy calculation of nStartHeight below if there's nothing to compute
if (vToCompute.empty()) return state;

int nStartHeight = calculateStartHeight(pindexPrev, state, nPeriod, cache);

// Now walk forward and compute the state of descendants of pindexPrev
Expand Down